On Fri, 21 Feb 2025 14:49:21 +0100 Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote: > Hi Kory, > > On Tue, Feb 18, 2025 at 05:19:11PM +0100, Kory Maincent wrote: > > From: Kory Maincent (Dent Project) <kory.maincent@xxxxxxxxxxx> > > > > This patch expands the status information provided by ethtool for PSE c33 > > with current port priority and max port priority. It also adds a call to > > pse_ethtool_set_prio() to configure the PSE port priority. > > Thank you! Here are some comments... > > > --- a/Documentation/networking/ethtool-netlink.rst > > +++ b/Documentation/networking/ethtool-netlink.rst > > @@ -1790,6 +1790,12 @@ Kernel response contents: > > ``ETHTOOL_A_C33_PSE_PW_LIMIT_RANGES`` nested Supported power limit > > configuration ranges. > > ``ETHTOOL_A_PSE_PW_D_ID`` u32 Index of the PSE > > power domain > > + ``ETHTOOL_A_C33_PSE_BUDGET_EVAL_STRAT`` u32 Budget evaluation > > strategy > > + of the PSE > > + ``ETHTOOL_A_C33_PSE_PRIO_MAX`` u32 Priority maximum > > configurable > > + on the PoE PSE > > + ``ETHTOOL_A_C33_PSE_PRIO`` u32 Priority of the PoE > > PSE > > + currently configured > > > > Please remove _C33_ from these fields, as they are not specific to Clause 33. Oops, forgot to update the documentation accordingly. Thanks for spotting it. -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
