On 23/02/2025 18:30, Jonathan Cameron wrote:
On Wed, 19 Feb 2025 14:31:38 +0200
Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
The new devm_iio_adc_device_alloc_chaninfo() -helper is intended to help
drivers avoid open-coding the for_each_node -loop for getting the
channel IDs. The helper provides standard way to detect the ADC channel
nodes (by the node name), and a standard way to convert the "reg",
"diff-channels", "single-channel" and the "common-mode-channel" to
channel identification numbers used in the struct iio_chan_spec.
Furthermore, the helper checks the ID is in range of 0 ... num-channels.
The original driver treated all found child nodes as channel nodes. The
new helper requires channel nodes to be named channel[@N]. This should
help avoid problems with devices which may contain also other but ADC
child nodes. Quick grep from arch/* with the rzg2l_adc's compatible
string didn't reveal any in-tree .dts with channel nodes named
othervice. Also, same grep shows all the .dts seem to have channel IDs
between 0..num of channels.
Use the new helper.
Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
I should have read on. Definitely more convincing with these usecases.
however drag them to start of series. Better to add infrastructure
so some use and then on to your new driver.
Ok. I'll reorder the series.
I'll drop the differential channels support in v4 - and thus also the
expected property types parameters - which will simplify this and other
callers.
Thanks for taking a look at this!
Yours,
-- Matti
