Hi Laurent, Thank you for the review. On Sun, Feb 23, 2025 at 6:20 PM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > Hi Tommaso, > > Thank you for the patch. > > On Fri, Feb 21, 2025 at 04:55:23PM +0100, Tommaso Merciai wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > The RZ/V2H(P) SoC does not provide a `system` clock for the CSI-2 > > interface. To accommodate this, use `devm_clk_get_optional()` instead > > of `devm_clk_get()` when retrieving the clock. > > The clock shouldn't be optional. On all SoCs but V2H it should remain > mandatory, and on V2H you shouldn't call clk_get() at all. > > I'd recommend adding a flag to the rzg2l_csi2_info structure. > Agreed, in this case dtbs_check will not catch this issue if we pass "video" and "apb" clocks. Cheers, Prabhakar
