On 2025-02-21 12:09, Florian Fainelli wrote:
On 2/17/2025 5:36 PM, Kyle Hendry wrote:
Some BCM63268 bootloaders do not enable the internal PHYs by default.
This patch series adds a phy driver to set the registers required
for the gigabit PHY to work.
Currently the PHY can't be detected until the b53 switch is initialized,
but this should be solvable through the device tree. I'm currently
investigating whether the the PHY needs the whole switch to be set up
or just specific clocks, etc.
v2 changes:
- Remove changes to b53 dsa code and rework fix as a PHY driver
- Use a regmap for accessing GPHY control register
- Add documentaion for device tree changes
I really preferred v1 to v2 which conveyed the special intent better
than going through layers and layers of abstraction here with limited
re-usability.
At least with v2, the logic to toggle the IDDQ enable/disable remains
within the PHY driver which is a better location.
The next version should be much more simplified. I'm going to move
the syscon phandle to the actual phy node, so I think the device tree
documentation is going to need a new schema file for the phy. Who
should I list as the maintainer for the new binding?
Best regards,
Kyle
