Dne nedelja, 16. februar 2025 ob 10:27:12 Srednjeevropski standardni čas je Ryan Walklin napisal(a):
> From: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
>
> The Allwinner H616 has a display pipeline similar to other Allwinner
> devices, specifically the A10, but using a newer display engine
> revision (DE33).
>
> Not all output pins are exposed on all package variants, for example
> only the H700 and T507 have LCD pins exposed, but all variants support
> HDMI output. However on the die these are connected to a display engine
> via a TCON TOP and one or more timing controllers (TCONs).
>
> HDMI output support is not provided in this series (but will be in a
> subsequent patch) so for now note this within the relevant node to
> prevent a DT compiler error.
>
> Add TCON nodes for the TOP, and the LCD and TV timing controllers. The
> timing controllers are compatible with the existing R40 driver.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> Signed-off-by: Ryan Walklin <ryan@xxxxxxxxxxxxx>
> ---
> .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 133 ++++++++++++++++++
> 1 file changed, 133 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> index ab8b70ce7df89..242bac95840f8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> @@ -7,9 +7,12 @@
> #include <dt-bindings/clock/sun50i-h616-ccu.h>
> #include <dt-bindings/clock/sun50i-h6-r-ccu.h>
> #include <dt-bindings/clock/sun6i-rtc.h>
> +#include <dt-bindings/clock/sun8i-de2.h>
> +#include <dt-bindings/clock/sun8i-tcon-top.h>
> #include <dt-bindings/reset/sun50i-h616-ccu.h>
> #include <dt-bindings/reset/sun50i-h6-r-ccu.h>
> #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/reset/sun8i-de2.h>
>
> / {
> interrupt-parent = <&gic>;
> @@ -909,6 +912,136 @@ ohci3: usb@5311400 {
> status = "disabled";
> };
>
> + tcon_top: tcon-top@6510000 {
> + compatible = "allwinner,sun50i-h6-tcon-top";
> + reg = <0x06510000 0x1000>;
> + clocks = <&ccu CLK_BUS_TCON_TOP>,
> + <&ccu CLK_TCON_TV0>;
> + clock-names = "bus", "tcon-tv0";
> + clock-output-names = "tcon-top-tv0";
> + #clock-cells = <0>;
> + resets = <&ccu RST_BUS_TCON_TOP>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + tcon_top_mixer0_in: port@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> +
> + tcon_top_mixer0_in_mixer0: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&mixer0_out_tcon_top_mixer0>;
> + };
> + };
> +
> + tcon_top_mixer0_out: port@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> +
> + tcon_top_mixer0_out_tcon_lcd0: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&tcon_lcd0_in_tcon_top_mixer0>;
> + };
> +
> + tcon_top_mixer0_out_tcon_tv0: endpoint@2 {
> + reg = <2>;
> + remote-endpoint = <&tcon_tv0_in_tcon_top_mixer0>;
> + };
> + };
> +
> + tcon_top_hdmi_in: port@4 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <4>;
> +
> + tcon_top_hdmi_in_tcon_tv0: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&tcon_tv0_out_tcon_top>;
> + };
> + };
> +
> + tcon_top_hdmi_out: port@5 {
> + reg = <5>;
> +
> + tcon_top_hdmi_out_hdmi: endpoint {
> + /* placeholder for HDMI - remote-endpoint = <&hdmi_in_tcon_top>;*/
> + };
> + };
> + };
> + };
> +
> + tcon_lcd0: lcd-controller@6511000 {
> + compatible = "allwinner,sun8i-r40-tcon-lcd";
> + reg = <0x06511000 0x1000>;
> + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_TCON_LCD0>, <&ccu CLK_TCON_LCD0>;
> + clock-names = "ahb", "tcon-ch0";
> + clock-output-names = "tcon-data-clock";
> + #clock-cells = <0>;
> + resets = <&ccu RST_BUS_TCON_LCD0>, <&ccu RST_BUS_TCON_LCD1>;
> + reset-names = "lcd", "lvds";
That's not true, is it? LVDS should be LVDS reset. Check my WIP patch:
https://github.com/jernejsk/linux-1/commit/8b090dc866d4c4b5b0a1804da021a9f44c67d5f1
It turns out that H616 clock driver missed LVDS reset, as it can be seen here:
https://github.com/jernejsk/linux-1/commit/88bad1a59876f5d385bcd45a363784ed2beec6ae#diff-b340c978bcdbe240f7b99f4d0d96ea130a8acb1a5786a8efbb24d9e7a0b14e53R1084
I also commented on this series:
https://lore.kernel.org/linux-sunxi/20250213172248.158447-1-macroalpha82@xxxxxxxxx/T/#t
Best regards,
Jernej
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + tcon_lcd0_in: port@0 {
> + reg = <0>;
> +
> + tcon_lcd0_in_tcon_top_mixer0: endpoint {
> + remote-endpoint = <&tcon_top_mixer0_out_tcon_lcd0>;
> + };
> + };
> +
> + tcon_lcd0_out: port@1 {
> + reg = <1>;
> + };
> + };
> + };
> +
> + tcon_tv0: lcd-controller@6515000 {
> + compatible = "allwinner,sun50i-h6-tcon-tv",
> + "allwinner,sun8i-r40-tcon-tv";
> + reg = <0x06515000 0x1000>;
> + interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_TCON_TV0>,
> + <&tcon_top CLK_TCON_TOP_TV0>;
> + clock-names = "ahb", "tcon-ch1";
> + #clock-cells = <0>;
> + resets = <&ccu RST_BUS_TCON_TV0>;
> + reset-names = "lcd";
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + tcon_tv0_in: port@0 {
> + reg = <0>;
> +
> + tcon_tv0_in_tcon_top_mixer0: endpoint {
> + remote-endpoint = <&tcon_top_mixer0_out_tcon_tv0>;
> + };
> + };
> +
> + tcon_tv0_out: port@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> +
> + tcon_tv0_out_tcon_top: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&tcon_top_hdmi_in_tcon_tv0>;
> + };
> + };
> + };
> + };
> +
> rtc: rtc@7000000 {
> compatible = "allwinner,sun50i-h616-rtc";
> reg = <0x07000000 0x400>;
>
