On Thu, Feb 20, 2025 at 06:32:09PM +0800, Xu Yang wrote: > On Wed, Feb 19, 2025 at 01:01:30PM -0500, Frank Li wrote: > > On Wed, Feb 19, 2025 at 05:31:00PM +0800, Xu Yang wrote: > > > The i.MX95 USB2.0 controller is basically compatible with i.MX7D, > > > except it needs use hsio block control for wakeup setting. This will > > > add compatible for i.MX95 platform and restriciton on reg property. > > > > Nit: Simple said > > Add compatible ... > > > > Better mention "fsl,imx95-usbmisc" at subject. > > add compatible string "fsl,imx95-usbmisc" for ... The patch does a bit more than just add a compatible. 'Add i.MX95 support' is really enough. The diff is clear it is adding a compatible. Rob