BCM21664 is another chip from the Kona line of Broadcom SoCs, and its pinmux shares a lot of similarities with the BCM281xx pinmux. Add support for the BCM21664 pinmux controller to the BCM281xx driver. This also enables pinmux support for the BCM23550, which has an identical pinmux config to the BCM21664 (hence they can share a single compatible, brcm,bcm21664-pinctrl). While we're at it - fix a bug that affected higher registers in the BCM281XX driver and replace bare "unsigned" with "unsigned int" to comply with checkpatch requirements. Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx> --- By the way - while working on this patch, I noticed two things that are not implemented in mainline, but seem to be present in the pin controller regs according to the RDB[1][2]: - On both BCM21664 and BCM281XX, TRACE* pins only have two bits for DRV_STR and no HYST bit. That seems like it deserves its own pin type; however, since I don't know how to translate the reduced DRV_STR value to a drive strength in mA, I did not implement it. For now, I kept the same type for BCM21664 as for BCM281XX for these pins (standard). - On both BCM21664 and BCM281XX, two SIM-related pins (SIM and SIM2 on BCM281XX, SIMDAT and SSPDO on BCM21664) have extra PUPM0 and PUPM1 offsets (bits 11 and 12 respectively). Vendor kernel does not do anything with these bits, so I don't know what they do. If any Broadcom engineers could shed some light on these, I'd be grateful. Otherwise, neither of these are pressing issues, and this patchset is complete without them (they can be fixed in another patchset). [1] https://github.com/knuxdroid/android_kernel_samsung_baffinlite/blob/cm-12.1/arch/arm/mach-hawaii/include/mach/rdb/brcm_rdb_padctrlreg.h [2] https://github.com/s2plus/android_kernel_samsung_galaxys2plus/blob/cm-10.1_base-4.2/arch/arm/mach-capri/include/mach/rdb/brcm_rdb_padctrlreg.h --- Changes in v2: - Rebase on linux-pinctrl.git for-next branch, drop patch 2 ("pinctrl: bcm281xx: Fix incorrect regmap max_registers value") as it has been applied separately - Fix "initializer element is not a compile-time constant" warning - Fix unused variable warning - Simplify DT binding - Link to v1: https://lore.kernel.org/r/20250207-bcm21664-pinctrl-v1-0-e7cfac9b2d3b@xxxxxxxxx --- Artur Weber (6): dt-bindings: pinctrl: Add bindings for BCM21664 pin controller pinctrl: bcm281xx: Use "unsigned int" instead of bare "unsigned" pinctrl: bcm281xx: Provide pinctrl device info as OF platform data pinctrl: bcm281xx: Add support for BCM21664 pinmux ARM: dts: bcm2166x-common: Add pinctrl node ARM: dts: bcm2166x: Add bcm2166x-pinctrl DTSI .../bindings/pinctrl/brcm,bcm21664-pinctrl.yaml | 138 ++++ arch/arm/boot/dts/broadcom/bcm2166x-common.dtsi | 7 + arch/arm/boot/dts/broadcom/bcm2166x-pinctrl.dtsi | 297 +++++++ drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 849 +++++++++++++++++++-- 4 files changed, 1228 insertions(+), 63 deletions(-) --- base-commit: d01895c5b11849113e70f012d9d142f1d88852f0 change-id: 20250206-bcm21664-pinctrl-13cd7d3f7866 Best regards, -- Artur Weber <aweber.kernel@xxxxxxxxx>
