On Fri, Feb 21, 2025 at 04:24:29PM +0100, Krzysztof Kozlowski wrote: > v12.0 DPU on SM8750 comes with new CTL_PIPE_ACTIVE register for > selective activation of pipes, which replaces earlier > dpu_hw_ctl_setup_blendstage() code path for newer devices. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Changes in v3: > 1. New patch, split from previous big DPU v12.0. > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 9 +++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 29 +++++++++++++++++++++++++++-- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 8 ++++++++ > 4 files changed, 47 insertions(+), 2 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> Minot nit below > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c > index 43a254cf57da571e2ec8aad38028477652f9283c..3e0bdd1100ebb0d302a852ceeaf8af86835e69a1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c > @@ -40,6 +40,7 @@ > #define CTL_INTF_FLUSH 0x110 > #define CTL_CDM_FLUSH 0x114 > #define CTL_PERIPH_FLUSH 0x128 > +#define CTL_PIPE_ACTIVE 0x12C lowercase hex, please. > #define CTL_INTF_MASTER 0x134 > #define CTL_DSPP_n_FLUSH(n) ((0x13C) + ((n) * 4)) > -- With best wishes Dmitry
