On Thu, April 30, 2015 18:26, Rob Herring wrote: > On Thu, Apr 30, 2015 at 6:27 PM, Ilkka Koskinen > <ilkka.koskinen@xxxxxxxxxxxxxxx> wrote: >> Hi, >> >> On Wed, April 29, 2015 16:03, Rob Herring wrote: >>> On Wed, Apr 29, 2015 at 5:44 PM, Ilkka Koskinen >>> <ilkka.koskinen@xxxxxxxxxxxxxxx> wrote: >>>> From: Ilkka Koskinen <ilkka.koskinen@xxxxxxxxx> >>>> >>>> Add an empty version of of_get_next_parent() in order to avoid >>>> build error. >>> >>> Some details on the build error and what introduced it please. >> >> I agree. I'll add a better description of the issue in the commit >> message. >> >> Some background: I'm basically implementing a parser that deals >> with both device tree and ACPI. If OF hasn't been enabled, there's no >> declaration or implementation of the function. I'm not aware if any >> existing code in the kernel introduces the bug though. > > Then the build error is meaningless. Generally something like walking > up parents is only something core code would do and is why there is no > empty version. Your case may fit, but I'll have to wait and see your > code. So just include this in the series with the rest of your work. > I'll try not to run the other way when I see something ACPI related. > ;) Ok, sounds good to me. Thanks, Ilkka -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
