Re: [PATCH v5 3/5] gpio: spacemit: add support for K1 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2025/2/20 21:34, Bartosz Golaszewski wrote:
On Mon, Feb 17, 2025 at 1:58 PM Yixun Lan <dlan@xxxxxxxxxx> wrote:
[......]
+#define to_spacemit_gpio_bank(x) container_of((x), struct spacemit_gpio_bank, gc)
+
+struct spacemit_gpio;
+
+struct spacemit_gpio_bank {
+       struct gpio_chip                gc;
+       struct spacemit_gpio            *sg;
+       void __iomem                    *base;
+       u32                             index;
+       u32                             irq_mask;
+       u32                             irq_rising_edge;
+       u32                             irq_falling_edge;
+};
+
+struct spacemit_gpio {
+       struct  device                  *dev;
+       struct  spacemit_gpio_bank      sgb[NR_BANKS];
+};
Please don't use tabs in struct definitions.

Why not?I see https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#struct-declarations-and-initializers

[......]


_______________________________________________
linux-riscv mailing list
linux-riscv@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-riscv




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux