On Thu, Feb 20, 2025 at 01:11:41PM +0100, Paul Menzel wrote: > Dear Neeraj, > > > Thank you for your prompt reply. > > Am 20.02.25 um 12:59 schrieb Neeraj Sanjay Kale: > > > > Am 20.02.25 um 12:41 schrieb Neeraj Sanjay Kale: > > > > Allow user to set custom BD address for NXP chipsets. > > > > > > > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx> > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > > --- > > > > v2: Add allOf and unevaluatedProperties: false (Krzysztof) > > > > v3: Drop local-bd-address: true (Krzysztof) > > > > --- > > > > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 6 +++++- > > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > > > diff --git > > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > > b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > > > index 0a2d7baf5db3..a84c1c21b024 100644 > > > > --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > > > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > > > @@ -17,6 +17,9 @@ description: > > > > maintainers: > > > > - Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx> > > > > > > > > +allOf: > > > > + - $ref: bluetooth-controller.yaml# > > > > + > > > > properties: > > > > compatible: > > > > enum: > > > > @@ -43,7 +46,7 @@ properties: > > > > required: > > > > - compatible > > > > > > > > -additionalProperties: false > > > > +unevaluatedProperties: false > > > > > > How is this diff related to the change mentioned in the commit message? > > > > This is based on review comment from Krzysztof in V1 DT patch. > > allOf ref will import all properties defined in bluetooth-controller.yaml, including local-bd-address: > > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml#L18 > > Thank you. I’d include this in the commit message, but my comment was about > the replacement of `additionalProperties` by `unevaluatedProperties`. The change is needed to permit the property defined in bluetooth-controller.yaml to be used.
Attachment:
signature.asc
Description: PGP signature
