Re: [PATCH v1] riscv: dts: starfive: remove non-existent dac from jh7110

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> The jh7110 boards do not have a Rohm DAC on them as far as I
> can tell, and they certainly do not have a dh2228fv, as this device does
> not actually exist! Remove the dac nodes from the devicetrees as it is
> not acceptable to pretend to have a device on a board in order to bind
> the spidev driver in Linux.
>
> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Hmm.. I thought we already did this, but it must have been another board.
In any case

Reviewed-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx>

Thanks!
/Emil

> ---
> CC: Emil Renner Berthing <kernel@xxxxxxxx>
> CC: Conor Dooley <conor@xxxxxxxxxx>
> CC: Rob Herring <robh@xxxxxxxxxx>
> CC: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> CC: linux-riscv@xxxxxxxxxxxxxxxxxxx
> CC: devicetree@xxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> ---
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index dd2eefc295e5..c2f70f5e2918 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -350,12 +350,6 @@ &pwm {
>  &spi0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&spi0_pins>;
> -
> -	spi_dev0: spi@0 {
> -		compatible = "rohm,dh2228fv";
> -		reg = <0>;
> -		spi-max-frequency = <10000000>;
> -	};
>  };
>
>  &syscrg {
> --
> 2.45.2
>




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux