Hi, On Tue, Feb 18, 2025 at 02:59:04PM +0000, Wei Yang wrote: > On Thu, Feb 06, 2025 at 03:27:41PM +0200, Mike Rapoport wrote: > >From: "Mike Rapoport (Microsoft)" <rppt@xxxxxxxxxx> > > > >When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, init_reserved_page() > >function performs initialization of a struct page that would have been > >deferred normally. > > > >Rename it to init_deferred_page() to better reflect what the function does. > > Would it be confused with deferred_init_pages()? Why? It initializes a single page, deferred_init_pages() initializes many. > And it still calls __init_reserved_page_zone(), even we __SetPageReserved() > after it. Current logic looks not clear. There's no __init_reserved_page_zone(). Currently init_reserved_page() detects the zone of the page and calls __init_single_page(), so essentially it initializes one struct page. And we __SetPageReserved() in reserve_bootmem_region() after call to init_reseved_page() because pages there are indeed reserved. > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.