On Mon, Feb 17, 2025 at 02:10:50PM +0000, Russell King (Oracle) wrote: > On Mon, Feb 17, 2025 at 02:25:33PM +0100, Andrew Lunn wrote: > > > I am not sure all whether devices has this clock, but it appears in > > > the databook. So I think it is possible to move this in the core so > > > any platform with these clock can reuse it. > > > > Great > > > > The next problem will be, has everybody called it the same thing in > > DT. Since there has been a lot of cut/paste, maybe they have, by > > accident. > > Tegra186: "tx" > imx: "tx" > intel: "tx_clk" > rk: "clk_mac_speed" > s32: "tx" > starfive: "tx" > sti: "sti-ethclk" > The dwc-qos-eth also use clock name "tx", but set the clock with extra calibration logic. > so 50% have settled on "tx" and the rest are doing their own thing, and > that horse has already bolted. > The "rx" clock in s32 also uses the same logic. I think the core also needs to take it, as this rx clock is also mentioned in the databook. > I have some ideas on sorting this out, and I'm working on some patches > today. Great, Could you cc me when you submit them? So I can take it and change my series. Regards, Inochi
