On 17/02/2025 15:16, Heiko Stübner wrote: > Hi Steven, > > Am Montag, 17. Februar 2025, 15:47:21 MEZ schrieb Steven Price: >> On 05/02/2025 06:15, Shawn Lin wrote: >>> Inform firmware to keep the power domain on or off. >>> >>> Suggested-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> >>> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> >>> --- >> >> This patch is causing my Firefly RK3288 to fail to boot, it hangs >> shortly after reaching user space, but the bootup messages include the >> suspicious line "Bad mode in prefetch abort handler detected". >> I suspect the firmware on this board doesn't support this new SMC >> correctly. Reverting this patch on top of linux-next gets everything >> working again. > > Is your board actually running some trusted firmware? Not as far as I know. > Stock rk3288 never had tf-a / psci [0], I did work on that for a while, > but don't think that ever took off. > > I'm wondering who the smcc call is calling, but don't know about > about smcc stuff. Good question - it's quite possible things are blowing up just because there's nothing there to handle the SMC. My DTB is as upstream: cpus { #address-cells = <0x01>; #size-cells = <0x00>; enable-method = "rockchip,rk3066-smp"; rockchip,pmu = <0x06>; I haven't investigated why this code is attempting to call an SMC on this board. Steve > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/rockchip/rk3288.dtsi#n63 > >