> > Please be careful with the scope of these. Heiner is going through > > phylib and trying to reduce the scope of some of the functions we > > exporting in include/linux/phy.h to just being available in > > drivers/net/phy. That will help stop MAC drivers abuse them. We should > > do the same here, limit what can actually use these helpers to stop > > abuse. > > Can we consider having an header file sitting in drivers/net/phy > directly for this kind of things ? Yes, we then only need to worry about phy drivers, not MAC drivers. PHY driver writers tend to abuse things less. Andrew