On Mon, 2025-02-17 at 11:14 +1030, Andrew Jeffery wrote: > Hi Marshall, > > On Fri, 2025-02-14 at 09:15 +0800, MarshallZhan-wiwynn wrote: > > Set I3C config in yosemite4 DTS. > > > > Test plan: > > Tested pass with aspeed I3C patches and I3C hub driver. > > Can you please expand the commit message to provide details? This > statement is quite vague, and I don't find it terribly helpful as it > stands. Which aspeed patches? What tests? Also, you've sent this patch to the upstream lists and maintainers, but it appears you're intending this to be applied to the OpenBMC kernel fork. Please understand the difference between the two and review my recent response to Rush Chen: https://lore.kernel.org/all/9f0447151e6574d74e7fa9cbbb50d8e970059273.camel@xxxxxxxxxxxxxxxxxxxx/ Beyond that, for patches to be backported into the OpenBMC fork they should first be merged upstream, in which case they must be tested against a recent upstream tag (e.g. v6.14-r3) before they are sent. It will be worth reviewing the following: https://docs.kernel.org/process/development-process.html The "Submitting Patches" documentation provides a more succinct treatment: https://docs.kernel.org/process/submitting-patches.html If you have any questions, please feel free to contact myself or Joel off-list. Andrew
