On 16/02/2025 14:03, Krzysztof Kozlowski wrote: > On Fri, Feb 14, 2025 at 10:58:01PM +0100, Nikola Jelic wrote: >> Signed-off-by: Nikola Jelic <nikola.jelic83@xxxxxxxxx> >> >> --- >> V3 -> V4: review remarks > > You keep sending the same, not responding to comments and not fixing > them. Still nothing improved - same problems as v1. > > What above changelog even mean? > > Please respond to the feedback, the best to the v1 which you received, > that you acknowledge and implement it. If you have questions, then ask. > Sending something with the same mistakes for 5th or 6th time means we do > not understand each other. To recap, feedback from v1 to respond to: Please run scripts/checkpatch.pl and fix reported warnings. After that, run also `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Feedback from v3: go to v3 and respond or implement. Your changelog suggests nothing changed or it is just not precise enough. Best regards, Krzysztof
