Re: [PATCH 0/2] arm64: dts: imx8m: Add pinctrl config definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
Sent: Friday, February 14, 2025 5:28 PM
 
>Hi Maud,

>Am Freitag, dem 14.02.2025 um 16:57 +0100 schrieb Maud Spierings via B4
>Relay:
>> Up untill now the extra function mux (pull resistor, etc) has been
>> defined as a raw hex value, this is difficult to interpret. Add
>> definitions for these parts of the pinctrl registers to allow for more
>> readable pinctrl definitions in devictree files.

>I certainly prefer the short form with the hex value, I find that quite
>a bit more readable than very verbose swathes of defines ORed together.
>But each to their own.

I personally prefer it, but it would be accepted if I write a dts using this if it
gets accepted? I am currently working on devicetrees for all of our devices
preferably they would use this.

>> At this point the patch is not complete, some pinctrl definitions set
>> bit 30 (0x40000000) but according to the reference manual this is a
>> reserved field, I currently have no way to identify what the meaning of
>> this bit is, I hope someone in this CC may be able to provide an answer
>> to this. It will then be fixed in the v2 of this patch.

>This is not a mystery bit, it's used by the pinctrl driver to force
>enable the input path of the pad (SION). This is defined in the generic
>i.MX pinctrl binding, see
>Documentation/devicetree/bindings/pinctrl/fsl,imx-pinctrl.txt

I had a suspicion that it was that but got confused because that is a different
register. Will change it to that in v2 somewhere next week.

Kind regards,
Maud Spierings






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux