On Thu, Feb 13, 2025 at 10:56:45PM +0100, Alexander Sverdlin wrote: > From: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> > > Add RTC devicetree binding for Sophgo CV1800 SoC. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> > --- > .../bindings/rtc/sophgo,cv1800-rtc.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > new file mode 100644 > index 000000000000..b36b51a69166 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Real Time Clock of the Sophgo CV1800 SoC > + > +description: > + Real Time Clock (RTC) is an independently powered module > + within the chip, which includes a 32KHz oscillator and a > + Power On Reset/POR submodule. It can be used for time display > + and timed alarm generation. In addition, the hardware state > + machine provides triggering and timing control for chip > + power on, off, and reset. > + > +maintainers: > + - Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> > + > +allOf: > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + const: sophgo,cv1800-rtc Now I prefer cv1800b to cv1800, using wildcard to provide base compatible is not a good idea. This old design should be changed. Otherwise, it looks good to me. With the compatible change: Reviewed-by: Inochi Amaoto <inochiama@xxxxxxxxx> Regards, Inochi
