On Sun, Feb 09, 2025 at 09:39:25PM +0100, David Heidelberg wrote:
> Convert the Analog Devices ad5820 to DT schema format.
>
> Signed-off-by: David Heidelberg <david@xxxxxxx>
> ---
> Needs: media: dt-bindings: media: i2c: align filenames format with standard
Well, it shouldn't. No need to rename the TXT file if you are going to
remove it in other patch,
>
> .../bindings/media/i2c/adi,ad5820.txt | 28 ---------
> .../bindings/media/i2c/adi,ad5820.yaml | 62 +++++++++++++++++++
> 2 files changed, 62 insertions(+), 28 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/adi,ad5820.txt
> create mode 100644 Documentation/devicetree/bindings/media/i2c/adi,ad5820.yaml
>
...
> + reg:
> + maxItems: 1
> +
> + enable-gpios:
> + maxItems: 1
> + description:
> + GPIO spec for the XSHUTDOWN pin. The XSHUTDOWN signal is active low,
> + a high level on the pin enables the device.
> +
> + VANA-supply:
> + description: supply of voltage for VANA pin
> +
> + "#io-channel-cells":
> + const: 0
This wasn't in original binding, so needs explanation why in the commit
msg.
> +
> +required:
> + - compatible
> + - reg
> + - VANA-supply
> + - '#io-channel-cells'
use consistent quotes, either ' or "
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
Use 4 spaces for example indentation.
Best regards,
Krzysztof
