On Wed, Feb 12, 2025 at 06:36:37PM +0200, Svyatoslav Ryhel wrote: > ср, 12 лют. 2025 р. о 18:10 Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> пише: > > On Wed, Feb 12, 2025 at 05:20:04PM +0200, Svyatoslav Ryhel wrote: > > > ср, 12 лют. 2025 р. о 16:28 Andy Shevchenko > > > <andriy.shevchenko@xxxxxxxxxxxxxxx> пише: > > > > On Wed, Feb 12, 2025 at 08:46:56AM +0200, Svyatoslav Ryhel wrote: ... > > > > > +#include <linux/i2c.h> > > > > > +#include <linux/module.h> > > > > > > > > > +#include <linux/of.h> > > > > > > > > No of*.h in the new code, please. > > > > > > > > > +#include <linux/regulator/consumer.h> > > > > > > > > Too small headers to be included. You use much more. > > > > > > Is there a check which determines the amount of headers I must include > > > and which headers are mandatory to be included and which are forbidden > > > to inclusion. Maybe at least a list? Thanks > > > > No check, there is IWYU principle. > > > > https://include-what-you-use.org/ > > > > The tool is not (yet?) suitable for the Linux kernel project and Jonathan, > > who is the maintainer of IIO code, had even tried it for real some time ago. > > So it is not adopted by the Linux kernel. > Lets return to this once it will be adopted. I understand you want to push your way, but here is the thing. This is a community of people and review is not something that comes for free. People, who are reviewing a code, want to make sure the code follows not only documented style, etc., but also common sense and the future maintenance. When a contributor comes and drops something into Linux Kernel project it adds a lot of work on maintainers' shoulders and other contributors who may be in progress of solving the other tasks. I specifically sent you a link where the tool and the principle is _explained_. So, it's not about the tool, it's about the whole project to become better and easier to maintain. You are a new guy in the development as you stated, so, please try to see how this all works. Of course, the last word here is Jonathan's as he is the maintainer of IIO, but I truly believe he will suggest you to follow my advice and not otherwise. > > > > > +#include <linux/iio/iio.h> > > > > > +#include <linux/iio/sysfs.h> ... I assume the non-commented parts you are satisfied with and they will be addressed as suggested. Thank you! -- With Best Regards, Andy Shevchenko
