On Wed, 12 Feb 2025 at 12:54, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 12/02/2025 11:41, Dmitry Baryshkov wrote: > > On Wed, Feb 12, 2025 at 03:12:24PM +0800, Yongxing Mou wrote: > >> We need to enable mst for qcs8300, dp0 controller will support 2 streams > >> output. So not reuse sm8650 dp controller driver and will add a new driver > >> patch for qcs8300 mst feature. Modify the corresponding dt-bingding file > >> to compatible with the qcs8300-dp. > > > > NAK for a different reason: QCS8300 is still compatible with SM8650. > > Enable features instead of randomly reshuffle compats. In this case, > > enable MST for both architectures. > > > So the original patch was probably correct... I have no idea. I'd let Yongxing Mou to comment on this. It would be nice instead of getting a lengthy explanation of obvious items to get an answer to an actual question: is QCS8300 compatible with SM8650 or not. In other words whether they can support the same number of MST streams on each controller or not. -- With best wishes Dmitry