On Tue, 2025-02-11 at 16:57 +0100, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 11/02/2025 13:59, Crystal Guo (郭晶) wrote: > > On Sun, 2025-02-09 at 11:52 +0100, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments > > > until > > > you have verified the sender or the content. > > > > > > > > > On 08/02/2025 05:40, Crystal Guo (郭晶) wrote: > > > > On Thu, 2024-12-12 at 11:58 +0100, Krzysztof Kozlowski wrote: > > > > > External email : Please do not click links or open > > > > > attachments > > > > > until > > > > > you have verified the sender or the content. > > > > > > > > > > > > > > > On 12/12/2024 09:59, Crystal Guo wrote: > > > > > > Add devicetree binding for mediatek common-dramc driver. > > > > > > > > > > > > The DRAM controller of MediaTek SoC provides an interface > > > > > > to > > > > > > get the current data rate of DRAM. > > > > > > > > > > Bindings are before users. > > > > > > Do not ignore comments but implement them or keep discussing. > > > > > > Best regards, > > > Krzysztof > > > > Got it, I have replied to the previous comments. Thanks for the > > reminder. > > > Ah, so these replies were because of this. Thanks, that makes sense, > although still two months after initial review, so I am out of the > context. > > I assume above also means you implement the feedback :) > > Best regards, > Krzysztof Yes, I have pushed the v2 patch based on these comments: https://patchwork.kernel.org/project/linux-mediatek/list/?series=931410 Changes in v2: - Remove pr_info and pr_err, use dev_err or dev_err_probe to print error message; - Replace module_init by module_platform_driver; - Remove unnecessary global variables; - Change fmeter-verison to platform data; - Remove mtk-dramc.h; - Refine compatible to "mediatek,mt8196-dramc"; - Refine CONFIG name to MEDIATEK_MC; - Fix yaml build errors, remove unnecessary properties on yaml file. Please help review this new version, thanks. Best regards Crystal
