On Wed, Apr 29, 2015 at 11:57:37AM +0100, Lee Jones wrote: > Does this looks okay to you Charles? > > > This patch add device tree bindings for the pdata needed to configure > > the Accessory Detect Mode select when Headphone detection. > > Isn't the idea of headphone detection that it headphones are detected > i.e. automatically? > Yeah, pretty much the chip can run an impedance measurement on either the left or the right headphone pin and to complicate things a little further you don't necessarily have to wire that to the actual headphones in hardware. So people tend to wire up all sorts of odd things that they thought sounded awesome. So you do really need a way to inform the driver which pin is actually going to be useful for measuring the headphone impedance on a specific system. In an ideal world we would just measure both and take the average, but in practice it is very dependent on how the hardware is wired up. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
