On Sun, Feb 09, 2025 at 01:09:04PM +0100, Lorenzo Bianconi wrote: > This patch adds the NPU document binding for EN7581 SoC. > The Airoha Network Processor Unit (NPU) provides a configuration interface > to implement wired and wireless hardware flow offloading programming Packet > Processor Engine (PPE) flow table. > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > --- > .../devicetree/bindings/arm/airoha,en7581-npu.yaml | 71 ++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/airoha,en7581-npu.yaml b/Documentation/devicetree/bindings/arm/airoha,en7581-npu.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..a5bcfa299e7cd54f51e70f7ded113f1efcd3e8b7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/airoha,en7581-npu.yaml arm is for top-level nodes, this has to go to proper directory or as last-resort to the soc. > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/airoha,en7581-npu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Airoha Network Processor Unit for EN7581 SoC > + > +maintainers: > + - Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > + > +description: > + The Airoha Network Processor Unit (NPU) provides a configuration interface > + to implement wired and wireless hardware flow offloading programming Packet > + Processor Engine (PPE) flow table. Sounds like network device, so maybe net? > + > +properties: > + compatible: > + items: > + - enum: > + - airoha,en7581-npu > + - const: syscon > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 15 You need to list the items. > + > + memory-region: > + maxItems: 1 > + description: > + Phandle to the node describing memory used to store NPU firmware binary. s/Phandle to the node describing// Best regards, Krzysztof
