[AMD Official Use Only - AMD Internal Distribution Only] > -----Original Message----- > From: Borislav Petkov <bp@xxxxxxxxx> > Sent: Thursday, January 16, 2025 3:57 AM > To: Datta, Shubhrajyoti <shubhrajyoti.datta@xxxxxxx> > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; > Conor Dooley <conor+dt@xxxxxxxxxx>; Tony Luck <tony.luck@xxxxxxxxx>; James > Morse <james.morse@xxxxxxx>; Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx>; Robert Richter <rric@xxxxxxxxxx>; linux- > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx; > git (AMD-Xilinx) <git@xxxxxxx> > Subject: Re: [PATCH v5 1/5] cdx: export the symbols > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Mon, Jan 06, 2025 at 11:03:54AM +0530, Shubhrajyoti Datta wrote: > > export the symbols for modules. > > Which modules are going to use those? Why? The versal_rpmsg_edac is going to use the calls. > > Why is this patch in this set? EDAC: Versal NET: Add support for error notification Uses the calls So I thought of adding in same series. > > This commit message is largely inadequate. Your other commit messages too. > > Yeah, the goal is for our commit messages to be as clear to humans as possible, > even for people who do not have intimate knowledge of the matter. > > And, more importantly, when we start doing git archeology months, years from now, > it should be perfectly clear why a commit was done. > > So please try to explain the issue in a clear and detailed way. Will update the commit message and resend > > People and you yourself will be thankful for it. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette
