Hi, Krzysztof. >-----Original Message----- >From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> >Sent: Tuesday, February 11, 2025 2:24 AM >To: Nas Chung <nas.chung@xxxxxxxxxxxxxxx>; mchehab@xxxxxxxxxx; >hverkuil@xxxxxxxxx; sebastian.fricke@xxxxxxxxxxxxx; robh@xxxxxxxxxx; >krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx >Cc: linux-media@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx; linux-imx@xxxxxxx; linux-arm- >kernel@xxxxxxxxxxxxxxxxxxx; jackson.lee <jackson.lee@xxxxxxxxxxxxxxx>; >lafley.kim <lafley.kim@xxxxxxxxxxxxxxx> >Subject: Re: [PATCH 1/8] media: platform: chips-media: wave5: Rename >Kconfig parameter > >On 10/02/2025 10:07, Nas Chung wrote: >> The existing Kconfig parameter VIDEO_WAVE_VPU is ambiguous, >> as it does not clearly indicate that it is specific to the Wave5 IP. >> >> Rename VIDEO_WAVE_VPU to VIDEO_WAVE5_VPU to make it explicit >> that the parameter is specific to the Wave5 IP. >> >> No functional changes, only the parameter name is updated. > > >That's unnecessary churn. Old name was fine. Kconfig does not match >hardware 1-to-1 but represents only the driver name (or not even that...). > >If you solve any particular problem, then explain it. Otherwise this is >just unnecessarily affecting users and backports. I understand your point. To avoid unnecessary changes, I'll drop this patch. Thank you for your feedback. Thanks. Nas. > >> >> Signed-off-by: Nas Chung <nas.chung@xxxxxxxxxxxxxxx> >> --- >> arch/arm64/configs/defconfig | 2 +- > >That's a SoC patch, don't mix up subsystems. > > >Best regards, >Krzysztof
