Re: [PATCH RESEND v5] arm64: dts: qcom: Add coresight nodes for x1e80100

[Jie Gan <quic_jiegan@xxxxxxxxxxx>]

On 2/10/2025 9:47 PM, Johan Hovold wrote:
> On Thu, Dec 05, 2024 at 01:49:03PM +0800, Jie Gan wrote:
> > Add following coresight components for x1e80100 platform.
> > It includes CTI, dummy sink, dynamic Funnel, Replicator, STM,
> > TPDM, TPDA and TMC ETF.
> >
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > Tested-by: Yushan Li <quic_yushli@xxxxxxxxxxx>
> > Signed-off-by: Jie Gan <quic_jiegan@xxxxxxxxxxx>
>
> This patch is now in 6.14-rc1 and results in the logs being spammed with
> 200+ messages about cyclic dependencies. I'd expect something like this
> to at least be mentioned in the commit message:
>
> [    0.250732] /soc@0/stm@10002000: Fixed dependency cycle(s) with /soc@0/funnel@10041000
> [    0.250854] /soc@0/tpda@10004000: Fixed dependency cycle(s) with /soc@0/funnel@10041000
> [    0.250881] /soc@0/tpda@10004000: Fixed dependency cycle(s) with /soc@0/tpdm@1000f000
> [    0.251011] /soc@0/tpdm@1000f000: Fixed dependency cycle(s) with /soc@0/tpda@10004000
> [    0.251128] /soc@0/funnel@10041000: Fixed dependency cycle(s) with /soc@0/funnel@10045000
> [    0.251155] /soc@0/funnel@10041000: Fixed dependency cycle(s) with /soc@0/stm@10002000
> [    0.251184] /soc@0/funnel@10041000: Fixed dependency cycle(s) with /soc@0/tpda@10004000
> [    0.251251] /soc@0/funnel@10042000: Fixed dependency cycle(s) with /soc@0/funnel@10045000
> [    0.251329] /soc@0/funnel@10042000: Fixed dependency cycle(s) with /soc@0/funnel@10c2c000
> [    0.251359] /soc@0/funnel@10042000: Fixed dependency cycle(s) with /soc@0/funnel@10ac5000
> [    0.251388] /soc@0/funnel@10042000: Fixed dependency cycle(s) with /soc@0/funnel@10cc5000
> [    0.251449] /soc@0/funnel@10045000: Fixed dependency cycle(s) with /soc@0/funnel@10b04000
> [    0.251538] /soc@0/funnel@10045000: Fixed dependency cycle(s) with /soc@0/funnel@10042000
> [    0.251571] /soc@0/funnel@10045000: Fixed dependency cycle(s) with /soc@0/funnel@10041000
> ...
> [    0.301268] /soc@0/tpda@10d12000: Fixed dependency cycle(s) with /soc@0/tpdm@10d08000
> [    0.301462] /soc@0/tpda@10d12000: Fixed dependency cycle(s) with /soc@0/funnel@10d13000
> [    0.301520] /soc@0/funnel@10d04000: Fixed dependency cycle(s) with /soc@0/funnel@10d13000
> [    0.301582] /soc@0/funnel@10d13000: Fixed dependency cycle(s) with /soc@0/funnel@10d04000
> [    0.301639] /soc@0/funnel@10d13000: Fixed dependency cycle(s) with /soc@0/tpda@10d12000
>
> [    0.317624] Callback from call_rcu_tasks() invoked.
>
> Has anyone looked into what is causing this and if anything can be done
> about it?
>
> This is taking a fair amount of time to process and print.
>
> Johan

Hi Johan,

These lines have been printed by following API, 
fw_devlink_create_devlink, it's pr_info:

...
	device_links_write_lock();
	if (__fw_devlink_relax_cycles(link->consumer, sup_handle)) {
		__fwnode_link_cycle(link);
		pr_debug("----- cycle: end -----\n");
		pr_info("%pfwf: Fixed dependency cycle(s) with %pfwf\n",
			link->consumer, sup_handle);
	}
...

https://elixir.bootlin.com/linux/v6.14-rc1/source/drivers/base/core.c

I am not sure we can change it to pr_debug to decrease annoying messages.

Thanks,
Jie