On 2/8/25 3:31 PM, Markus Elfring wrote: > … >> +++ b/drivers/firmware/samsung/exynos-acpm.c >> @@ -0,0 +1,771 @@ > … >> +static int acpm_dequeue_by_polling(struct acpm_chan *achan, >> + const struct acpm_xfer *xfer) >> +{ > … >> + do { >> + mutex_lock(&achan->rx_lock); >> + ret = acpm_get_rx(achan, xfer); >> + mutex_unlock(&achan->rx_lock); > … > > Under which circumstances would you become interested to apply a statement > like “guard(mutex)(&achan->rx_lock);”? > https://elixir.bootlin.com/linux/v6.13.1/source/include/linux/mutex.h#L201 I'll replace the open-coded mutex handling with cleanup.h guard(mutex) and scoped_guard(mutex, ...), thanks. Cheers, ta