On Fri, Feb 07, 2025 at 11:47:12PM +0100, Konrad Dybcio wrote: > On 13.01.2025 10:46 PM, Melody Olvera wrote: > > Add UFS support for SM8750 SoCs. > > > > Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> > > --- > > Nitin Rawat (5): > > dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: Document the SM8750 QMP UFS PHY > > phy: qcom-qmp-ufs: Add PHY Configuration support for SM8750 > > dt-bindings: ufs: qcom: Document the SM8750 UFS Controller > > arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC > > arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 QRD and MTP boards > > You still need the same workaround 8550/8650 have in the UFS driver > (UFSHCD_QUIRK_BROKEN_LSDBS_CAP) for it to work reliably, or at least > that was the case for me on a 8750 QRD. > > Please check whether we can make that quirk apply based on ctrl > version or so, so that we don't have to keep growing the compatible > list in the driver. > That would be a bizarre. When I added the quirk, I was told that it would affect only SM8550 and SM8650 (this one I learned later). I'm not against applying the quirk based on UFSHC version if the bug is carried forward, but that would be an indication of bad design. - Mani -- மணிவண்ணன் சதாசிவம்
