Hi
On 20:29 Sun 09 Feb , Inochi Amaoto wrote:
> Reuse reset-simple driver for the Sophgo CV1800B reset generator.
>
> Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>
> ---
> drivers/reset/reset-simple.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c
> index 276067839830..79e94ecfe4f5 100644
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -151,6 +151,8 @@ static const struct of_device_id reset_simple_dt_ids[] = {
> { .compatible = "snps,dw-high-reset" },
> { .compatible = "snps,dw-low-reset",
> .data = &reset_simple_active_low },
> + { .compatible = "sophgo,cv1800b-reset",
> + .data = &reset_simple_active_low },
I think this isn't really a problem, but..
quite a lot SoCs use the "simple active low" IP,
can we introduce a generic compatible? so can set as fallback..
intead of growing this compatible data each time for new SoC
> { .compatible = "sophgo,sg2042-reset",
> .data = &reset_simple_active_low },
> { /* sentinel */ },
> --
> 2.48.1
>
--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55
