On Mon, Feb 3, 2025 at 6:52 AM Nick Chan <towinchenmi@xxxxxxxxx> wrote: > > Apple SoCs come with a 2-wire interface named DWI. On some iPhones, iPads > and iPod touches the backlight controller is connected via this interface. > This series adds a backlight driver for backlight controllers connected > this way. > > Changes since v4: > - Change type to BACKLIGHT_PLATFORM since the driver does not directly > interface with the backlight controller. The actual backlight controller > can be directly controlled via i2c and is not the same on all hardware > that supports the dwi interface. > - Rename file to apple_dwi_bl.c to better match config option. > - Rename driver to apple-dwi-bl to better match config option > - Indicate that the backlight scales linearly > > v4: https://lore.kernel.org/asahi/20241211113512.19009-1-towinchenmi@xxxxxxxxx/T > > Changes since v3: > - $ref to common.yaml in bindings > - (and then additionalProperties is changed to unevaluatedProperties) > - Use hex everywhere in bindings example > - Use sizeof(*dwi_bl) instead of the type of the struct when doing > devm_kzalloc() > - Use devm_platform_get_and_ioremap_resource() in driver > - Fix sorting in drivers/video/backlight/Makefile > - In drivers/video/backlight/Kconfig, move config to right after > BACKLIGHT_APPLE > - Explain this driver being completely different from apple_bl > > v3: https://lore.kernel.org/asahi/20241209075908.140014-1-towinchenmi@xxxxxxxxx/T > > Changes since v2: > - Add missing includes in driver > - Fix file path in MAINTAINERS > > v2: https://lore.kernel.org/asahi/20241207130433.30351-1-towinchenmi@xxxxxxxxx/T > > Changes since v1: > - Fixed dt-bindings $id. > - Make power-domains an optional property in dt-bindings. > - Added missing error checking after devm_ioremap_resource() in > dwi_bl_probe(). > > v1: https://lore.kernel.org/asahi/20241206172735.4310-1-towinchenmi@xxxxxxxxx/T > > Nick Chan > > --- > Nick Chan (3): > dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight > backlight: apple_dwi_bl: Add Apple DWI backlight driver > MAINTAINERS: Add entries for Apple DWI backlight controller > > .../bindings/leds/backlight/apple,dwi-bl.yaml | 57 ++++++++ > MAINTAINERS | 2 + > drivers/video/backlight/Kconfig | 12 ++ > drivers/video/backlight/Makefile | 1 + > drivers/video/backlight/apple_dwi_bl.c | 123 ++++++++++++++++++ > 5 files changed, 195 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml > create mode 100644 drivers/video/backlight/apple_dwi_bl.c > > > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > -- > 2.48.1 > > This series looks good to me. Reviewed-by: Neal Gompa <neal@xxxxxxxxx> -- 真実はいつも一つ！/ Always, there's only one truth!
