Hi Dragan, On Fri Feb 7, 2025 at 4:01 PM CET, Dragan Simic wrote: > On 2025-02-07 12:11, Diederik de Haas wrote: >> Add the recommended chassis-type root node property so userspace can >> request the form factor and adjust their behavior accordingly. >> >> Signed-off-by: Diederik de Haas <didi.debian@xxxxxxxxx> >> Link: >> https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node > > Maybe the Link tag should be converted into a "[1]" reference? > To me, this is more like a reference for this DT addition. > > In general, references can also be placed closer to the contents > they back up, which isn't possible with Link tags, but of course > that doesn't matter much in this case. I generally use the "[1]" format when linking to specific claims, which I could've done wrt the "recommended". But I considered this a general background link and then I prefer to do it via a Link tag. If requested by a maintainer I'll change it ofc, but otherwise I prefer to keep it as is. >> --- >> arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi >> index 2d3ae1544822..3613661417b2 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi >> @@ -9,6 +9,8 @@ >> #include "rk3566.dtsi" >> >> / { >> + chassis-type = "tablet"; >> + >> aliases { >> mmc0 = &sdhci; >> }; > > The patch is obviously fine. Thanks for the patch, and please feel > free to include, regardless of the note above, my: > > Reviewed-by: Dragan Simic <dsimic@xxxxxxxxxxx> Thanks :) Cheers, Diederik
Attachment:
signature.asc
Description: PGP signature
