On Thu, Feb 06, 2025 at 02:19:33PM +0100, Steffen Trumtrar wrote:
>
> Hi,
>
> On 2025-02-05 at 10:49 -06, "Rob Herring (Arm)" <robh@xxxxxxxxxx> wrote:
>
> > On Wed, 05 Feb 2025 16:32:23 +0100, Steffen Trumtrar wrote:
> > > Changes to the binding while converting:
> > > - add "snps,dwmac-3.7{0,2,4}a". They are used, but undocumented.
> > > - altr,f2h_ptp_ref_clk is not a required property but optional.
> > >
> > > Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> > > ---
> > > .../bindings/net/pcs/altr,gmii-to-sgmii.yaml | 47 ++++++++++
> > > .../devicetree/bindings/net/socfpga-dwmac.txt | 57 ------------
> > > .../devicetree/bindings/net/socfpga-dwmac.yaml | 102 +++++++++++++++++++++
> > > 3 files changed, 149 insertions(+), 57 deletions(-)
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/pcs/altr,gmii-to-sgmii.example.dtb:
> > phy@100000240: reg: [[1, 576], [8, 1], [512, 64]] is too short
> > from schema $id: http://devicetree.org/schemas/pcs/altr,gmii-to-sgmii.yaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/pcs/altr,gmii-to-sgmii.example.dtb:
> > phy@100000240: 'clock-names', 'clocks' do not match any of the regexes:
> > 'pinctrl-[0-9]+'
> > from schema $id: http://devicetree.org/schemas/pcs/altr,gmii-to-sgmii.yaml#
> >
> > doc reference errors (make refcheckdocs):
> >
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250205-v6-12-topic-socfpga-agilex5-v4-2-ebf070e2075f@xxxxxxxxxxxxxx
> >
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
>
> 'pipx upgrade dtschema' says I have version 2025.2, but I still don't get theses errors.
>
> make O=build dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/pcs/altr,gmii-to-sgmii.yaml
> make[1]: Entering directory '(...)'
> CHKDT (...)/Documentation/devicetree/bindings
> LINT (...)/Documentation/devicetree/bindings
> DTC [C] Documentation/devicetree/bindings/net/pcs/altr,gmii-to-sgmii.example.dtb
>
> Anything I'm missing or doing wrong?
Try:
make O=build dt_binding_check DT_SCHEMA_FILES=net/pcs/altr,gmii-to-sgmii.yaml
The full path should work, but seems there is some issue. But really,
DT_SCHEMA_FILES is just a sub-string to match with schema $id.
'reg' should be the number of logical entries (and what they are), not
the number of cells.
Rob
