Instead of directly using of_node_get() before of_find_node_by_name() to balance the refcount of the device_node, using wraper function of_find_node_by_name_balanced() to make code logic a bit simplier. Signed-off-by: Zhang Zekun <zhangzekun11@xxxxxxxxxx> --- drivers/net/dsa/hirschmann/hellcreek_ptp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dsa/hirschmann/hellcreek_ptp.c b/drivers/net/dsa/hirschmann/hellcreek_ptp.c index bfe21f9f7dcd..360ceb6831ed 100644 --- a/drivers/net/dsa/hirschmann/hellcreek_ptp.c +++ b/drivers/net/dsa/hirschmann/hellcreek_ptp.c @@ -307,8 +307,7 @@ static int hellcreek_led_setup(struct hellcreek *hellcreek) const char *label; int ret = -EINVAL; - of_node_get(hellcreek->dev->of_node); - leds = of_find_node_by_name(hellcreek->dev->of_node, "leds"); + leds = of_find_node_by_name_balanced(hellcreek->dev->of_node, "leds"); if (!leds) { dev_err(hellcreek->dev, "No LEDs specified in device tree!\n"); return ret; -- 2.22.0