On Thu, Feb 06, 2025 at 10:39:19AM +0200, Matti Vaittinen wrote: > On 05/02/2025 22:03, Conor Dooley wrote: > > On Wed, Feb 05, 2025 at 03:34:29PM +0200, Matti Vaittinen wrote: > > > Add binding document for the ROHM BD79124 ADC / GPO. > > > > > > ROHM BD79124 is a 8-channel, 12-bit ADC. The input pins can also be used > > > as general purpose outputs. > > > > > > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx> > > > --- > > > Revision history: > > > RFC v1 => v2: > > > - drop MFD and represent directly as ADC > > > - drop pinmux and treat all non ADC channel pins as GPOs > > > --- > > ... > > > > +patternProperties: > > > + "^channel@[0-9a-f]+$": > > > > You can only have 8 channels, there's no need for this to be so > > permissive, right? > > Otherwise, this looks good enough to me. > > Thanks Conor! > > Indeed, I think we only need to accept channel@0 .. channel@7. Thanks! > (And reason for this being permissive is ... drum roll ... copy-paste :) > That's my main method of creating the yaml bindings. Swearing, sweating, > copying and running the 'make dt_binding_check' > :rolleyes: > > I'll wait for a while for comments to the other patches and fix this for v3 > :) with it reduced, Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
