RE: [PATCH v2 5/8] arm64: dts: renesas: r9a09g057: Add support for enabling SDHI internal regulator

[Biju Das <biju.das.jz@xxxxxxxxxxxxxx>]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 06 February 2025 09:00
> Subject: Re: [PATCH v2 5/8] arm64: dts: renesas: r9a09g057: Add support for enabling SDHI internal
> regulator
> 
> Hi Biju,
> 
> On Fri, 31 Jan 2025 at 12:29, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Add support for enabling SDHI internal regulator, by overriding the
> > status on the board DTS, when needed.
> >
> > While at it, rename the gpio regulator label
> > vqmmc_sdhi1->vqmmc_sdhi1_gpio to avoid conflicts with internal regulator node names.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> > @@ -602,6 +602,13 @@ sdhi0: mmc@15c00000  {
> >                         resets = <&cpg 0xa7>;
> >                         power-domains = <&cpg>;
> >                         status = "disabled";
> > +
> > +                       vqmmc_sdhi0: vqmmc-regulator {
> 
> sdhi0_vqmmc

OK.

> 
> > +                               regulator-name = "SDHI0-VQMMC";
> > +                               regulator-min-microvolt = <1800000>;
> > +                               regulator-max-microvolt = <3300000>;
> > +                               status = "disabled";
> > +                       };
> >                 };
> >
> >                 sdhi1: mmc@15c10000 {
> > @@ -615,6 +622,13 @@ sdhi1: mmc@15c10000 {
> >                         resets = <&cpg 0xa8>;
> >                         power-domains = <&cpg>;
> >                         status = "disabled";
> > +
> > +                       vqmmc_sdhi1: vqmmc-regulator {
> 
> sdhi1_vqmmc

OK.

> 
> > +                               regulator-name = "SDHI1-VQMMC";
> > +                               regulator-min-microvolt = <1800000>;
> > +                               regulator-max-microvolt = <3300000>;
> > +                               status = "disabled";
> > +                       };
> >                 };
> >
> >                 sdhi2: mmc@15c20000 {
> > @@ -628,6 +642,13 @@ sdhi2: mmc@15c20000 {
> >                         resets = <&cpg 0xa9>;
> >                         power-domains = <&cpg>;
> >                         status = "disabled";
> > +
> > +                       vqmmc_sdhi2: vqmmc-regulator {
> 
> sdhi2_vqmmc
OK.
> 
> > +                               regulator-name = "SDHI2-VQMMC";
> > +                               regulator-min-microvolt = <1800000>;
> > +                               regulator-max-microvolt = <3300000>;
> > +                               status = "disabled";
> > +                       };
> >                 };
> >         };
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
> > b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
> > index 0b705c987b6c..1ecea3872e94 100644
> > --- a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
> > @@ -53,7 +53,7 @@ reg_3p3v: regulator1 {
> >                 regulator-always-on;
> >         };
> >
> > -       vqmmc_sdhi1: regulator-vccq-sdhi1 {
> > +       vqmmc_sdhi1_gpio: regulator-vccq-sdhi1 {
> >                 compatible = "regulator-gpio";
> >                 regulator-name = "SDHI1 VccQ";
> >                 gpios = <&pinctrl RZV2H_GPIO(A, 2) GPIO_ACTIVE_HIGH>;
> > @@ -244,7 +244,7 @@ &sdhi1 {
> >         pinctrl-1 = <&sdhi1_pins>;
> >         pinctrl-names = "default", "state_uhs";
> >         vmmc-supply = <&reg_3p3v>;
> > -       vqmmc-supply = <&vqmmc_sdhi1>;
> > +       vqmmc-supply = <&vqmmc_sdhi1_gpio>;
> >         bus-width = <4>;
> >         sd-uhs-sdr50;
> >         sd-uhs-sdr104;
> 
> And then there is (a) no need to change the names here, and (b) no build failure in
> arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts.

Agreed. Will fix this in next version.

Cheers,
Biju