Hi Biju,
On Fri, 31 Jan 2025 at 12:25, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Enable SDHI1 on the RZ/G3E SMARC EVK platform using gpio regulator for
> voltage switching.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v1->v2:
> * Replaced the regulator usd_vdd_3p3v->reg_3p3v.
> * Renamed the gpio-hog node sd1-pwr-en->sd1-pwr-en-hog.
> * Sorted sd1 pin ctrl nodes.
Thanks for the update!
> --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> @@ -9,6 +9,7 @@
>
> /* Switch selection settings */
> #define SW_SD0_DEV_SEL 0
> +#define SW_SDIO_M2E 0
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/pinctrl/renesas,r9a09g047-pinctrl.h>
> @@ -20,6 +21,16 @@ / {
> model = "Renesas SMARC EVK version 2 based on r9a09g047e57";
> compatible = "renesas,smarc2-evk", "renesas,rzg3e-smarcm",
> "renesas,r9a09g047e57", "renesas,r9a09g047";
> +
> + vqmmc_sd1_pvdd: regulator-vqmmc-sd1-pvdd {
> + compatible = "regulator-gpio";
> + regulator-name = "SD1_PVDD";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&pinctrl RZG3E_GPIO(1, 5) GPIO_ACTIVE_HIGH>;
This is the patch that needs to add #include <dt-bindings/gpio/gpio.h>.
> + gpios-states = <0>;
> + states = <3300000 0>, <1800000 1>;
> + };
> };
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
