Hello Laurent, Thank you for your review comments. > -----Original Message----- > From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Sent: Thursday, January 2, 2025 10:17 PM > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > <yuji2.ishikawa@xxxxxxxxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; Rob Herring > <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley > <conor+dt@xxxxxxxxxx>; Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>; Hans > Verkuil <hverkuil-cisco@xxxxxxxxx>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ > □ＤＩＴ○ＯＳＴ) <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>; > linux-media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v12 8/8] MAINTAINERS: Add entries for Toshiba Visconti > Video Input Interface > > Hi Ishikawa-san, > > Thank you for the patch. > > On Mon, Nov 25, 2024 at 06:21:46PM +0900, Yuji Ishikawa wrote: > > Added entries for visconti Video Input Interface driver, including; > > Commit messages are written using the imperative mood, as if you were giving > orders to someone: > > s/Added/Add/ > Thank you for the advice. I'll update commit messages. > > * device tree bindings > > * source files > > * documentation files > > > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> > > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > I would have added the MAINTAINERS entry in 1/8 with just the DT binding file, > and added more files in corresponding patches. That would be easier to review > and check if entries are missing. I don't mind much though, so if you prefer > keeping it this way: >
