> On 04/02/2025 17:15, Lorenzo Bianconi wrote:
> >> On 03/02/2025 17:04, Krzysztof Kozlowski wrote:
> >>>> +
> >>>> + rng@1faa1000 {
> >>>> + compatible = "airoha,en7581-trng";
> >>>> + reg = <0x0 0x1faa1000 0x0 0xc04>;
> >>>> + interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> >>>> + };
> >>>> +
> >>>> + system-controller@1fbf0200 {
> >>>> + compatible = "syscon", "simple-mfd";
> >>>
> >>> These are never allowed alone. I am pretty sure I added proper checks
> >>> which should point it out, so I think you did not really test your DTS.
> >>>
> >>> It does not look like you tested the DTS against bindings. Please run
> >>> `make dtbs_check W=1` (see
> >>> Documentation/devicetree/bindings/writing-schema.rst or
> >>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> >>> for instructions).
> >>> Maybe you need to update your dtschema and yamllint. Don't rely on
> >>> distro packages for dtschema and be sure you are using the latest
> >>> released dtschema.
> >>>
> >>
> >> Now I see Rob's report:
> >> arch/arm64/boot/dts/airoha/en7581-evb.dtb: system-controller@1fbf0200:
> >> compatible: ['syscon', 'simple-mfd'] is too short
> >> which confirms untested code. Schema is there for a reason. :(
> >
> > actually I have tested them with the following command (but without W=1).
> >
> > make CHECK_DTBS=y DT_SCHEMA_FILES=airoha airoha/en7581-evb.dtb
> >
> > - dtschema 2024.11
> > - yamllint 1.35.1
> >
> > With W=1 I can see more issues, I will fix issues in v2.
>
> Rob's warning does not come from W=1. Your test cmd was incorrect: drop
> DT_SCHEMA_FILES. You must test your code against ENTIRE bindings, not
> some subset.
ack, thx for pointing this out.
Regards,
Lorenzo
>
> Best regards,
> Krzysztof
Attachment:
signature.asc
Description: PGP signature
