Re: [PATCH v2 5/8] arm64: dts: renesas: r9a09g057: Add support for enabling SDHI internal regulator

[Nobuhiro Iwamatsu <iwamatsu@xxxxxxxxxxx>]

Hi Biju,


2025年2月4日(火) 18:48 Biju Das <biju.das.jz@xxxxxxxxxxxxxx>:
>
> Hi all,
>
> I need to send a patch for fixing the build issue for r9a09g057h48-kakip.dts
> as this board is introduced in latest renesas-devel/linux-next[1].
>
> I will send next version, after getting some feedback on the current series.
>
> arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts:42.36-50.4: ERROR (duplicate_label): /regulator-vccq-sdhi0: Duplicate label 'vqmmc_sdhi0' on /regulator-vccq-sdhi0 and /soc/mmc@15c00000/vqmmc-regulator
>

You may have already made a patch, but I also created a patch and
confirmed working.

diff --git a/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
index d2586d278769e2..090d9c69fd75ec 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
+++ b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
@@ -39,7 +39,7 @@ reg_3p3v: regulator-3v3 {
         regulator-always-on;
     };

-    vqmmc_sdhi0: regulator-vccq-sdhi0 {
+    vqmmc_sdhi0_gpio: regulator-vccq-sdhi0 {
         compatible = "regulator-gpio";
         regulator-name = "SDHI0 VccQ";
         gpios = <&pinctrl RZV2H_GPIO(A, 0) GPIO_ACTIVE_HIGH>;
@@ -129,7 +129,7 @@ &sdhi0 {
     pinctrl-0 = <&sdhi0_pins>;
     pinctrl-names = "default";
     vmmc-supply = <&reg_3p3v>;
-    vqmmc-supply = <&vqmmc_sdhi0>;
+    vqmmc-supply = <&vqmmc_sdhi0_gpio>;
     bus-width = <4>;

     status = "okay";

> Cheers,
> Biju

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org / kernel.org}
   GPG ID: 32247FBB40AD1FA6