On Tue, Feb 04, 2025 at 04:02:44PM +1300, Chris Packham wrote: > Add bindings for the ethernet-switch portion of the RTL9300. > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > --- > > Notes: > Changes in v6: > - New > - I'd like to enforce the property being "ethernet-ports" but I see the > generic binding allows "ports" as well. Can I just add ethernet-ports: > type: object here or does by driver need to handle both "ports" and > "ethernet-ports" (I see some do and some don't). > > .../bindings/mfd/realtek,rtl9301-switch.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml > index f053303ab1e6..cb54abda5e6a 100644 > --- a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml > +++ b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml > @@ -14,6 +14,8 @@ description: > number of different peripherals are accessed through a common register block, > represented here as a syscon node. > > +$ref: /schemas/net/ethernet-switch.yaml# > + > properties: > compatible: > items: > @@ -45,7 +47,7 @@ required: > - compatible > - reg > I don't get why this device receives now children without addresses. Either your children have 'reg' or they do not. Mixing is a sign of a mess, like this was never actually simple-mfd. You would get this comment if you posted complete schema the first time. Best regards, Krzysztof
