On Fri, Jan 31, 2025 at 04:33:48PM -0500, Frank Li wrote: > Add binding doc for reset controller of i.MX8QM and i.MX8QXP, which use > System Controller Firmware(SCU) reset some peripherals, such as CSI. > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > .../devicetree/bindings/reset/fsl,imx-scu.yaml | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-scu.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-scu.yaml > new file mode 100644 > index 0000000000000..6046df8723262 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/fsl,imx-scu.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/fsl,imx-scu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX8 SCU Reset > + > +maintainers: > + - Frank Li <Frank.Li@xxxxxxx> > + > +description: > + i.MX8QM and i.MX8QXP System Controller Firmware(SCU) provide reset for > + some peripheral. > + > +properties: > + compatible: > + enum: > + - fsl,imx-scu-reset > + > + '#reset-cells': > + const: 1 > + > +required: > + - compatible > + - '#reset-cells' > + > +additionalProperties: false > + > +examples: > + - | > + reset-controller { > + compatible = "fsl,imx-scu-reset"; > + #reset-cells = <1>; This should just be a property in the parent SCU node. You don't need a node for every provider. We need a binding for the SCU as a whole. Rob