On Fri, Jan 31, 2025 at 07:13:50PM +0100, Artur Weber wrote: > The BCM59054 MFD is fairly similar to the BCM59056, and will use > the same driver. Add compatible and specify the allowed regulator > nodes. > > Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx> [snip] > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: brcm,bcm59054 > + then: > + properties: > + regulators: > + $ref: ../regulator/brcm,bcm59054.yaml Full path. > + > + - if: > + properties: > + compatible: > + contains: > + const: brcm,bcm59056 > + then: > + properties: > + regulators: > + $ref: ../regulator/brcm,bcm59056.yaml Full path. > + > examples: > - | > #include <dt-bindings/interrupt-controller/arm-gic.h> > diff --git a/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml b/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..719621c7f0e71cd9368f4d7243c79aaa97ca7255 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/brcm,bcm59054.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM59054 Power Management IC regulators > + > +description: | > + This is a part of device tree bindings for the BCM590XX family of power > + management ICs. Same comment as patch 1. > + > + See also Documentation/devicetree/bindings/mfd/brcm,bcm59056.yaml for > + additional information and example. > + > +maintainers: > + - Artur Weber <aweber.kernel@xxxxxxxxx> > + > +# The valid regulator node names for BCM59054 are: > +# rfldo, camldo1, camldo2, simldo1, simldo2, sdldo, sdxldo, > +# mmcldo1, mmcldo2, audldo, micldo, usbldo, vibldo, > +# csr, iosr1, iosr2, mmsr, sdsr1, sdsr2, vsr, > +# gpldo1, gpldo2, gpldo3, tcxldo, lvldo1, lvldo2 Same comment as patch 1. > + > +patternProperties: > + "^(cam|sim|mmc)ldo[1-2]$": > + type: object > + $ref: /schemas/regulator/regulator.yaml# As Rob's bot pointed out, you're missing unevaluatedProperties: false in all of these. Regards, Stanislav
