It's not obvious to me what the point of this patch is. Why are we
making this change? There is no changelog.
> @@ -482,9 +483,9 @@ long st_kim_start(void *kim_data)
> pdata->chip_enable(kim_gdata);
>
> /* Configure BT nShutdown to HIGH state */
These comments are misleading now.
> - gpio_set_value(kim_gdata->nshutdown, GPIO_LOW);
> + gpio_set_value(kim_gdata->nshutdown, kim_gdata->shutdown_val);
> mdelay(5); /* FIXME: a proper toggle */
> - gpio_set_value(kim_gdata->nshutdown, GPIO_HIGH);
> + gpio_set_value(kim_gdata->nshutdown, !kim_gdata->shutdown_val);
> mdelay(100);
> /* re-initialize the completion */
> reinit_completion(&kim_gdata->ldisc_installed);
> @@ -566,11 +567,11 @@ long st_kim_stop(void *kim_data)
> }
>
> /* By default configure BT nShutdown to LOW state */
This as well.
> - gpio_set_value(kim_gdata->nshutdown, GPIO_LOW);
> + gpio_set_value(kim_gdata->nshutdown, kim_gdata->shutdown_val);
> mdelay(1);
> - gpio_set_value(kim_gdata->nshutdown, GPIO_HIGH);
> + gpio_set_value(kim_gdata->nshutdown, !kim_gdata->shutdown_val);
> mdelay(1);
> - gpio_set_value(kim_gdata->nshutdown, GPIO_LOW);
> + gpio_set_value(kim_gdata->nshutdown, kim_gdata->shutdown_val);
>
> /* platform specific disable */
> if (pdata->chip_disable)
> @@ -749,6 +750,7 @@ static struct ti_st_plat_data *get_platform_data(struct device *dev)
> @@ -817,7 +821,8 @@ static int kim_probe(struct platform_device *pdev)
> }
>
> /* Configure nShutdown GPIO as output=0 */
This comment.
> - err = gpio_direction_output(kim_gdata->nshutdown, GPIO_LOW);
> + err = gpio_direction_output(kim_gdata->nshutdown,
> + kim_gdata->shutdown_val);
> if (unlikely(err)) {
> pr_err(" unable to configure gpio %d", kim_gdata->nshutdown);
> return err;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
