Re: [PATCH v5 2/5] soc: renesas: rz-sysc: Move RZ/G3S SoC detection to the SYSC driver

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Tue, 28 Jan 2025 at 04:14, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Now that we have SoC detection in the RZ SYSC driver, move the RZ/G3S SoC
> detection to it. The SYSC provides SoC ID in its own registers.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> ---
> Changes:
> v5: Hardcoded SoC-specific register offsets and masks

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v6.15.

> --- /dev/null
> +++ b/drivers/soc/renesas/r9a08g045-sysc.c

> +static const struct rz_sysc_soc_id_init_data rzg3s_sysc_soc_id_init_data __initconst = {
> +       .family = "RZ/G3S",
> +       .id = 0x85e0447,
> +       .devid_offset = 0xa04,
> +       .revision_mask = 0xf0000000,
> +       .specific_id_mask = 0x0fffffff,

I'll replace these two lines by

    .revision_mask = GENMASK(31, 28),
    .specific_id_mask = GENMASK(27, 0),

while applying, here and in all subsequent patches.

> +};

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds