Hi Krzysztof,
Thanks for Reviewing the patch.
On Thu, 23 Jan 2025 08:26:08 +0100, Krzysztof Kozlowski wrote:
> > Add of_platform_default_populate() to stratix10-svc driver as the
> > firmware/svc node was moved out of soc.
> > This fixes the failed probing of child drivers of svc node.
> >
> > Fixes: 23c3ebed382a ("arm64: dts: socfpga: agilex: move firmware out
> > of soc node")
> >
>
>
> There is never a blank line between tags. Use: `git log`
>
> > Signed-off-by: Mahesh Rao <mahesh.rao@xxxxxxxxx>
Understood, I will revise this in the next revision.
>
> > ---
> > drivers/firmware/stratix10-svc.c | 14 +++++++++++---
> > 1 file changed, 11 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/firmware/stratix10-svc.c
> > b/drivers/firmware/stratix10-svc.c
> > index
> > platform_device_unregister(svc->stratix10_svc_rsu);
> > err_free_kfifo:
> > kfifo_free(&controller->svc_fifo);
>
>
> You need to update remove() callback.
>
Sure, I will add the changes in the next revision.
Best regards,
Mahesh Rao
