On 1/28/2025 5:02 PM, Konrad Dybcio wrote: > On 28.01.2025 10:41 AM, Raj Kumar Bhagat wrote: >> On 1/28/2025 2:52 PM, Krzysztof Kozlowski wrote: >>> On 28/01/2025 10:10, Raj Kumar Bhagat wrote: >>>> + /* Default Profile >>>> + * +============+==============+=====================+ >>>> + * | | | | >>>> + * | Region | Start Offset | Size | >>>> + * | | | | >>>> + * +------------+--------------+---------------------+ >>>> + * | | | | >>>> + * | | | | >>>> + * | | | | >>>> + * | WLAN Q6 | 0x4A900000 | 43MB | >>>> + * | | | | >>>> + * | | | | >>>> + * +------------+--------------+---------------------+ >>>> + * | M3 Dump | 0x4D400000 | 1MB | >>>> + * +============+==============+=====================+ >>>> + * | | >>>> + * | | >>>> + * | | >>>> + * | Rest of memory for Linux | >>>> + * | | >>>> + * | | >>>> + * | | >>>> + * +=================================================+ >>>> + */ >>>> + >>>> + reserved-memory { >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>>> + ranges; >>>> + >>>> + q6_region: wcss@4a900000 { >>>> + reg = <0x0 0x4a900000 0x0 0x02b00000>; >>>> + no-map; >>>> + }; >>>> + >>>> + m3_dump: m3-dump@4d400000 { >>> >>> This fails with your wireless patchset. >>> >> >> Yes, this will fail with v4 wireless patch. >> We have v5 (yet to be sent) to read the correct reserved memory. Since, >> in v4 I was asked to address and send DTS patch separately, The corresponding >> driver patches are yet to be sent. > > I think the intention was to send them separately, but together time-wise, so > that the large set of net changes is somewhat shrunk, but the reviewers can > cross-reference both series if/as needed > Yes, the intention is similar: to get DT related reviews before posting the next version (v5) of the driver changes. >> >>>> + reg = <0x0 0x4D400000 0x0 0x100000>; > > Please use lowercase hex > Thanks, will do in next version.