Hi Biju,
On Tue, 28 Jan 2025 at 11:48, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Add interrupt control node to RZ/G3E ("R9A09G047") SoC DTSI
> and add icu as interrupt-parent of pincontrol.
>
> Also, define the ICU IRQs for board DT users.
>
> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> @@ -8,6 +8,24 @@
> #include <dt-bindings/clock/renesas,r9a09g047-cpg.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> +#define RZG3E_NMI 0
> +#define RZG3E_IRQ0 1
> +#define RZG3E_IRQ1 2
> +#define RZG3E_IRQ2 3
> +#define RZG3E_IRQ3 4
> +#define RZG3E_IRQ4 5
> +#define RZG3E_IRQ5 6
> +#define RZG3E_IRQ6 7
> +#define RZG3E_IRQ7 8
> +#define RZG3E_IRQ8 9
> +#define RZG3E_IRQ9 10
> +#define RZG3E_IRQ10 11
> +#define RZG3E_IRQ11 12
> +#define RZG3E_IRQ12 13
> +#define RZG3E_IRQ13 14
> +#define RZG3E_IRQ14 15
> +#define RZG3E_IRQ15 16
Do you need these definitions? And why here, not in <dt-bindings/...>?
The similar RZ/V2H ICU does not use such definitions.
The DT bindings clearly document the meaning of the cell value, and
the numbers can be looked up in Table 4.6-24 ("List of Input Events")
of the documentation, so I think it can be removed.
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
